Skip to content

B001 ModelicaSystem split#426

Open
syntron wants to merge 1 commit intoOpenModelica:masterfrom
syntron:B001-ModelicaSystem_split
Open

B001 ModelicaSystem split#426
syntron wants to merge 1 commit intoOpenModelica:masterfrom
syntron:B001-ModelicaSystem_split

Conversation

@syntron
Copy link
Contributor

@syntron syntron commented Feb 27, 2026

(B001) split ModelicaSystem

[ModelicaSystem] split ModelicaSystem into ModelicaSystemABC and ModelicaSystem

[ModelicaSystem] rename ModelicaSystem => ModelicaSystemOMC

* add compatibility variable for ModelicaSystem

[test_ModelicaSystemOMC] rename from ModelicaSystem and update

[test_*] use ModelicaSystemOMC

[ModelicaSystem*] fix last usages of ModelicaSystem() in comments & docstrings

@syntron syntron changed the title B001 modelica system split B001 ModelicaSystem split Feb 27, 2026
@syntron syntron mentioned this pull request Feb 27, 2026
Draft
@syntron syntron force-pushed the B001-ModelicaSystem_split branch 2 times, most recently from 59e6c9d to 946a091 Compare March 13, 2026 17:11
@adeas31
Copy link
Member

adeas31 commented Mar 18, 2026

[ModelicaSystem] split ModelicaSystem into ModelicaSystemABC and ModelicaSystem

[ModelicaSystem] rename ModelicaSystem => ModelicaSystemOMC

We could do ModelicaSystemBase instead of ModelicaSystemABC and ModelicaSystem instead of ModelicaSystemOMC. This requires less changes both in the code base and for the users.

@syntron
Copy link
Contributor Author

syntron commented Mar 18, 2026

[ModelicaSystem] split ModelicaSystem into ModelicaSystemABC and ModelicaSystem

[ModelicaSystem] rename ModelicaSystem => ModelicaSystemOMC

We could do ModelicaSystemBase instead of ModelicaSystemABC and ModelicaSystem instead of ModelicaSystemOMC. This requires less changes both in the code base and for the users.

This is done on purpose; a later change (PR #437) creates a compatibility layer => ModelicaSystem is used there.

*ABC is used to indicate an uncomplete class => there are functions missing which are just added in the derived classes *OMC or *Runner. This is handled for ModelicaSystem*, OM(C)Session* and Modelica(System)DoE*. See PR #441, PR #442 and PR #443.

@syntron
(B001) split ModelicaSystem
46eb63d 
[ModelicaSystem] split ModelicaSystem into ModelicaSystemABC and ModelicaSystem

[ModelicaSystem] rename ModelicaSystem => ModelicaSystemOMC

* add compatibility variable for ModelicaSystem

[test_ModelicaSystemOMC] rename from ModelicaSystem and update

[test_*] use ModelicaSystemOMC

[ModelicaSystem*] fix last usages of ModelicaSystem() in comments & docstrings
@syntron syntron force-pushed the B001-ModelicaSystem_split branch from 946a091 to 46eb63d Compare March 18, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@syntron @adeas31